feat: dialect mapColumnType

teaql-postgres/src/main/java/io/teaql/core/postgres/PostgresDataServiceExecutor.java

@@ -39,9 +39,6 @@ public int[] batchUpdate(String sql, List<Object[]> batchArgs) {
 
             @Override
             public void execute(String sql) {
-                if (sql != null) {
-                    sql = sql.replace("<max>", "255");
-                }
                 getExecutionAdapter().execute(sql);
             }
 

teaql-sql-portable/src/main/java/io/teaql/core/sql/dialect/MySqlDialect.java

@@ -39,4 +39,12 @@ public String buildSubsidiaryInsertSql(String tableName, List<String> tableColum
                 escapeIdentifier(tableName),
                 tableColumns.stream().map(c -> escapeIdentifier(c) + " = ?").collect(Collectors.joining(" , ")));
     }
+
+    @Override
+    public String mapColumnType(String type) {
+        if (type != null && type.contains("<max>")) {
+            return type.replace("VARCHAR(<max>)", "LONGTEXT").replace("<max>", "65535");
+        }
+        return type;
+    }
 }

teaql-sql-portable/src/main/java/io/teaql/core/sql/dialect/OracleDialect.java

@@ -29,4 +29,12 @@ public String getPartitionSQL() {
     public String buildSubsidiaryInsertSql(String tableName, java.util.List<String> tableColumns) {
         throw new UnsupportedOperationException("Subsidiary insert not implemented for Oracle yet");
     }
+
+    @Override
+    public String mapColumnType(String type) {
+        if (type != null && type.contains("<max>")) {
+            return type.replace("VARCHAR(<max>)", "CLOB").replace("<max>", "4000");
+        }
+        return type;
+    }
 }

teaql-sql-portable/src/main/java/io/teaql/core/sql/dialect/PostgreSqlDialect.java

@@ -50,4 +50,12 @@ public String buildSubsidiaryInsertSql(String tableName, List<String> tableColum
         return StrUtil.format("INSERT INTO {} ({}) VALUES ({}) ON CONFLICT ({}) DO UPDATE SET {}",
                 escapeIdentifier(tableName), columnsStr, valuesStr, escapeIdentifier("id"), updateSetStr);
     }
+
+    @Override
+    public String mapColumnType(String type) {
+        if (type != null && type.contains("<max>")) {
+            return type.replace("VARCHAR(<max>)", "TEXT").replace("<max>", "255");
+        }
+        return type;
+    }
 }

teaql-sql-portable/src/main/java/io/teaql/core/sql/dialect/SqlDialect.java

@@ -26,4 +26,11 @@ public interface SqlDialect {
      * For Postgres this could be INSERT ... ON CONFLICT DO UPDATE.
      */
     String buildSubsidiaryInsertSql(String tableName, List<String> columns);
+
+    /**
+     * Map a generic column type (like VARCHAR(<max>)) to a dialect-specific type (like TEXT or VARCHAR(MAX)).
+     */
+    default String mapColumnType(String type) {
+        return type;
+    }
 }

teaql-sql-portable/src/main/java/io/teaql/core/sql/portable/PortableSQLRepository.java

@@ -641,7 +641,7 @@ protected void createTable(UserContext ctx, String table, List<SQLColumn> column
         sb.append("CREATE TABLE ").append(table).append(" (\n");
         sb.append(columns.stream()
                 .map(column -> {
-                    String dbColumn = column.getColumnName() + " " + column.getType();
+                    String dbColumn = dialect.escapeIdentifier(column.getColumnName()) + " " + dialect.mapColumnType(column.getType());
                     if (column.isIdColumn()) dbColumn += " PRIMARY KEY";
                     return dbColumn;
                 })
@@ -655,7 +655,7 @@ protected void createTable(UserContext ctx, String table, List<SQLColumn> column
 
     protected void addColumn(UserContext ctx, SQLColumn column) {
         String sql = StrUtil.format("ALTER TABLE {} ADD COLUMN {} {}",
-                column.getTableName(), column.getColumnName(), column.getType());
+                dialect.escapeIdentifier(column.getTableName()), dialect.escapeIdentifier(column.getColumnName()), dialect.mapColumnType(column.getType()));
         logInfo(sql + ";");
         if (ensureTableEnabled(ctx)) {
             try { database.execute(ctx, sql); } catch (Exception e) { logInfo("Ignored: " + e.getMessage()); }