Repository navigation
fix(ingestion/tests): FakeSectionStore missing upsert_document_and_replace_sections method, crashing Scenario A/B tests #272
Description
Summary
ingestion/tests/conftest.py's FakeSectionStore implements replace_sections and upsert_document separately, but the production pipeline calls section_store.upsert_document_and_replace_sections() (the atomic combined method) for Scenario A/B paths. Any test that exercises ingest_document() with a Scenario A/B PDF will crash with AttributeError: 'FakeSectionStore' object has no attribute 'upsert_document_and_replace_sections'.
Root Cause
ingestion/tests/conftest.py around line 160:
class FakeSectionStore:
def replace_sections(self, doc_id, rows): ...
def upsert_document(self, ...): ...
# upsert_document_and_replace_sections is NOT implementedingestion/pipeline.py (Scenario A/B path):
await section_store.upsert_document_and_replace_sections(
tenant_id, doc_id, sections, ingest_status, ...
) # ← AttributeError in tests using FakeSectionStoreFailure Scenario
- Test creates a
FakeSectionStoreand passes it toingest_document(). - Pipeline detects Scenario A (has native TOC) or B (has heuristic headers).
- Pipeline calls
section_store.upsert_document_and_replace_sections(...). AttributeError: 'FakeSectionStore' object has no attribute 'upsert_document_and_replace_sections'.- Test crashes with ERROR instead of FAILED — masking as a setup problem, not a real test failure.
- The atomic Scenario A/B upsert path is never actually tested.
Proposed Fix
Add the missing method to FakeSectionStore:
class FakeSectionStore:
def __init__(self):
self._sections: dict[tuple[str, str], list] = {}
self._documents: dict[str, dict] = {}
def upsert_document_and_replace_sections(
self,
tenant_id: str,
doc_id: str,
sections: list,
ingest_status: str,
fallback_only: bool,
**kwargs,
) -> None:
key = (tenant_id, doc_id)
self._documents[key] = {
'doc_id': doc_id,
'tenant_id': tenant_id,
'ingest_status': ingest_status,
'fallback_only': fallback_only,
}
self._sections[key] = sectionsAlso add a Protocol compliance test:
def test_fake_section_store_satisfies_protocol():
from ingestion.store_protocol import SectionStore
store = FakeSectionStore()
assert isinstance(store, SectionStore)
Activity
piyushmakhija28 commentedon Jun 21, 2026
Fixed in PR #280 (Sprint R3/R4: fix(sprint-r3): root-cause fixes for all 39 bugs from code review round 3 + Sprint R4 round 4)