Skip to content

fix(tests): test_production_stores.py calls replace_sections with old 2-arg signature after #256 added tenant_id #285

Closed

Description

@piyushmakhija28

Summary

test_production_stores.py at lines 155 and 158 calls store.replace_sections("doc_1", first) with the old 2-arg signature. But fix #256 updated SqlAlchemySectionStore.replace_sections to require 3 args: (tenant_id, doc_id, rows). The test passes "doc_1" as tenant_id and the list[SectionRow] as doc_id, causing TypeError on every test run.

Fix

ingestion/tests/test_production_stores.py lines 155, 158: add tenant_id as the first argument, e.g. store.replace_sections("test-tenant", "doc_1", first).

Impact

test_production_stores.py fails with TypeError on every run.

Activity

  1. added
    bugSomething isn't working
    priority: highData loss, security, or major correctness bug
    code-reviewFound via automated code review
    on Jun 21, 2026
  2. piyushmakhija28 commented on Jun 21, 2026

    @piyushmakhija28
    ContributorAuthor

    Fixed in PR #280 (Sprint R3/R4: fix(sprint-r3): root-cause fixes for all 39 bugs from code review round 3 + Sprint R4 round 4)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    bugSomething isn't workingcode-reviewFound via automated code reviewpriority: highData loss, security, or major correctness bug

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions