Skip to content

fix(tests): test_adapters.py total_pages assertion fails -- fake_ingest result dict missing total_pages key #291

Closed

Description

@piyushmakhija28

Summary

test_maps_pipeline_result_to_outcome in tests/test_adapters.py at line ~458 asserts outcome.total_pages == 12. But fake_ingest result dict has no 'total_pages' key. PipelineIngestor reads result.get("total_pages") or 0, returning 0. The assertion fails every run.

Fix

tests/test_adapters.py: add "total_pages": 12 to the fake_ingest result dict fixture so the adapter has the key available.

Impact

test_maps_pipeline_result_to_outcome fails on every run.

Activity

  1. added
    bugSomething isn't working
    priority: highData loss, security, or major correctness bug
    code-reviewFound via automated code review
    on Jun 21, 2026
  2. piyushmakhija28 commented on Jun 21, 2026

    @piyushmakhija28
    ContributorAuthor

    Fixed in PR #280 (Sprint R3/R4: fix(sprint-r3): root-cause fixes for all 39 bugs from code review round 3 + Sprint R4 round 4)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    bugSomething isn't workingcode-reviewFound via automated code reviewpriority: highData loss, security, or major correctness bug

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions