Skip to content

fix(tests): test_adapters.py thinking type assertion stale -- production sends enabled/budget_tokens not adaptive #293

Closed

Description

@piyushmakhija28

Summary

test_stream_answer_yields_tokens in tests/test_adapters.py at line ~714 asserts thinking == {"type": "adaptive"}. But ClaudeGenerationLLM sends {"type": "enabled", "budget_tokens": 5000} to the Anthropic API. The assertion is stale and fails every run.

Fix

tests/test_adapters.py line ~714: update assertion to match current production code:
assert thinking == {"type": "enabled", "budget_tokens": 5000}

Impact

test_stream_answer_yields_tokens fails on every run. Thinking parameter configuration is untested.

Activity

  1. added
    bugSomething isn't working
    priority: highData loss, security, or major correctness bug
    code-reviewFound via automated code review
    on Jun 21, 2026
  2. piyushmakhija28 commented on Jun 21, 2026

    @piyushmakhija28
    ContributorAuthor

    Fixed in PR #280 (Sprint R3/R4: fix(sprint-r3): root-cause fixes for all 39 bugs from code review round 3 + Sprint R4 round 4)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    bugSomething isn't workingcode-reviewFound via automated code reviewpriority: highData loss, security, or major correctness bug

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions