Skip to content

Task #0000 chore: Add docs for lms services and assesment services#35

Open
kkbiswal wants to merge 4 commits into
tekdi:mainfrom
kkbiswal:lmsdoc
Open

Task #0000 chore: Add docs for lms services and assesment services#35
kkbiswal wants to merge 4 commits into
tekdi:mainfrom
kkbiswal:lmsdoc

Conversation

@kkbiswal
Copy link
Copy Markdown

No description provided.

Copy link
Copy Markdown

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces comprehensive documentation for the Assessment and LMS microservices, covering architectural designs, features, database schemas, API specifications, and local setup instructions. The review feedback identifies several areas for improvement, including resolving inconsistencies in database naming and enum values across different documents, fixing sidebar position conflicts, and removing empty headers or redundant parameters in the API documentation. Additionally, there are minor typos in the database schema and incomplete @todo placeholders that need to be addressed to ensure the documentation is accurate and professional.

Comment thread docs/assessment-service/8_devops.md
| currentPosition | double precision | NOT NULL, DEFAULT 0 |
| timeSpent | integer | DEFAULT 0 |
| updatedBy | uuid | |
| updatedAt | timestamp without time zone | NO, DEFAULT now() |
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

Typo in the constraints column for the updatedAt field. NO should be NOT NULL to maintain consistency with other timestamp fields in the schema.

Comment thread docs/assessment-service/7_api-docs.md Outdated
Comment thread docs/assessment-service/7_api-docs.md Outdated
- **Bearer Token**: JWT-based authentication (configured in Swagger)
- **Header-based**: Multi-tenancy through required headers

### Common Response Format
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

This header is empty. Please provide the common response format details or remove the header.

Comment thread docs/assessment-service/7_api-docs.md Outdated
@@ -0,0 +1,78 @@
---
sidebar_position: 3
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

Sidebar position conflict: both 3_getting-started.md and installation.md are assigned position 3. Consider adjusting the positions to ensure correct ordering in the sidebar.

Comment thread docs/assessment-service/8_devops.md Outdated
Comment thread docs/lms-service/8_devops.md Outdated
Comment thread docs/assessment-service/7_api-docs.md Outdated
Comment thread docs/assessment-service/7_api-docs.md Outdated
@sonarqubecloud
Copy link
Copy Markdown

sonarqubecloud Bot commented May 6, 2026

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant