node: sign bridge vote-extensions via checkpoint/attestation RPCs#1034
node: sign bridge vote-extensions via checkpoint/attestation RPCs#1034diorwave wants to merge 7 commits into
Conversation
|
The reason for this pr is to protect the signer from unauthorised tx. With blind sign someone with access to the layer server can steal the funds. |
…alidated-bridge-signing # Conflicts: # go.mod # go.sum
efe5983 to
324cc32
Compare
|
right, node now signs via checkpoint/attestation rpcs, so blind SignRaw can be dropped and a compromised layer server cant steal funds. |
|
Hey @krasi-georgiev, I'd like to combine #1013 and #1034 into one PR. Your validated signing approach is the right one now that the sidecar disables blind signing; I just want to fold in a bit of #1013's structure on top since its small signer interface is cleaner than implementing the whole keyring. Could I do that on your branch so it stays your PR? |
…d fix gofumpt/gci formatting
On the maintainer side, the latest commit's checks are in Regarding @akremstudy's suggestion to combine this with #1013, I'm happy either way. I can rebase this onto #1013 or keep the PRs separate, whichever you prefer. |
SignOracleAttestation; node asserts the returned 64-byte sig equals the expected value.