Feat/Allow the Withdraw Reporter Rewards to Free Floating Balance #1049
Merged
Conversation
…hdraw tips directly to an unbonding like state where it will go straight to free floating balance instead of directly to stake
Contributor
|
Nice, maybe bound the # of times ProcessMatureTipUnlocks can run in one endblocker ? Could do a fifo queue like ProcessDistributionQueue(ctx, 10), something like: func (k Keeper) ProcessMatureTipUnlocks(ctx context.Context, limit int) error {
...
toProcess := make([]collections.Pair[int64, uint64], 0, limit)
err := k.TipUnlockQueue.Walk(ctx, rng, func(key ..., _ ...) (bool, error) {
toProcess = append(toProcess, key)
return len(toProcess) >= limit, nil // stop iterating — don't load the whole mature set
})
...
} |
…hdraw tips directly to an unbonding like state where it will go straight to free floating balance instead of directly to stake
…ng dust to the account before the upgrade
danflo27
approved these changes
Jul 16, 2026
akremstudy
approved these changes
Jul 16, 2026
brendaloya
enabled auto-merge (squash)
July 17, 2026 14:09
CJPotter10
disabled auto-merge
July 17, 2026 14:25
CJPotter10
enabled auto-merge (squash)
July 17, 2026 14:25
brendaloya
disabled auto-merge
July 17, 2026 14:25
brendaloya
pushed a commit
that referenced
this pull request
Jul 17, 2026
) (#1052) * added 2 new transactions and a query around allowing reporters to withdraw tips directly to an unbonding like state where it will go straight to free floating balance instead of directly to stake * made lint fixes * fixed another lint issue * added 2 new transactions and a query around allowing reporters to withdraw tips directly to an unbonding like state where it will go straight to free floating balance instead of directly to stake * added an upper iteration bound to the process unlock tips end blocker function * made lint-fixes * made the module account creation handle the scenario of someone sending dust to the account before the upgrade * changed a variable (cherry picked from commit ecaf4bf) Co-authored-by: CJPotter10 <91627020+CJPotter10@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Added two transactions to allow for withdrawing reporter rewards to free floating balance. One transaction allows reporters/selectors to withdraw their available tips to the tips_unlock_pool where after the unbonding period has passed they will be sent to free floating balance. The other transaction allows users to cancel pending tip unlocks back to their available tips where they can instead withdraw to their stake if they wish to.
New query for retrieving pending tip unlocks by selector address
Related Issue
Fixes #1038
Type of Change
Testing
add unit tests and integration tests
Checklist