fix(view): preserve zero attribute bindings#2171
Open
WarLikeLaux wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Expression attributes used a loose falsy check, so numeric zero values like
0,0.0, and"0"were omitted from rendered attributes. That dropped meaningful data values such asdata-start-percent="0". The renderer now omitsfalse,null, and values that normalize to an empty string, while preserving zero values.Literal expression attributes passed into view components used the same loose fallback and could turn
:foo="0"intotrue. That path now only falls back totruefor empty shorthand attributes.Fixes #2167