Add BillingReportGranularity to BillingReportSpec#114
Open
mksample wants to merge 2 commits into
Open
Conversation
mksample
commented
May 12, 2026
| // The description for the billing report. | ||
| // Optional, default is empty. | ||
| string description = 4; | ||
| // The data granularity of the billing report. |
Contributor
Author
There was a problem hiding this comment.
all copied directly from saas-proto
shakeelrao
reviewed
May 12, 2026
| // temporal:versioning:min_version=v0.16.0 | ||
| BillingReportGranularity granularity = 5; | ||
|
|
||
| // temporal:versioning:min_version=v0.16.0 |
Contributor
There was a problem hiding this comment.
nit: you can technically remove this.
shakeelrao
approved these changes
May 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What was changed
Why?
Checklist
Closes
How was this tested:
Note
Medium Risk
Medium risk because this changes the public protobuf API surface and will require regenerated clients/servers to correctly default/handle the new enum field.
Overview
Adds a new
BillingReportSpec.granularityfield (tag5) with aBillingReportGranularityenum (HOURLY,DAILY,MONTHLY) and a versioning annotation (min_version=v0.16.0) to control the data resolution of generated billing reports.Reviewed by Cursor Bugbot for commit 419d712. Bugbot is set up for automated code reviews on this repo. Configure here.