migrate Versioning3Suite by stephanos · Pull Request #10144 · temporalio/temporal

stephanos · 2026-05-01T03:57:26Z

What changed?

Migrate Versioning3Suite to use parallelsuite.

Added two legacy modes for compatibility as the suite showed issues otherwise:

(1) parallelsuite legacy mode: run sequentially
(2) testenv legacy mode: use single cluster only

Why?

Make cosmetic changes, ship them, adjust runtime behavior later.

stephanos · 2026-05-01T14:53:42Z

-		farm.Fingerprint32([]byte(fullName)),
-	)
-	return strings.Replace(short, ".", "|", -1)
-}


stephanos · 2026-05-01T21:57:06Z

 }

 func (s *Versioning3Suite) TestSessionActivityResourceSpecificTaskQueueNotRegisteredInVersion() {
-	tv := testvars.New(s)
-
-	ctx, cancel := context.WithTimeout(context.Background(), time.Minute)


one big change here is removing these contexts; they are all placed with simply env.Context() which has a default timeout. so they are not really needed (and can sometimes be too aggressiv for CI).

stephanos · 2026-05-01T21:57:35Z

@@ -72,124 +70,133 @@ const (
 	versionStatusRamping  = versionStatus(3)
 	versionStatusDraining = versionStatus(4)
 	versionStatusDrained  = versionStatus(5)
+
+	versioning3DeploymentWorkflowVersion = workerdeployment.VersionDataRevisionNumber


parallelsuite doesn't allow fields so this was moved here - it seems to be readonly anyway

stephanos · 2026-05-01T21:58:38Z

@@ -1411,7 +1393,7 @@ func (s *Versioning3Suite) testDoubleTransition(unversionedSrc bool, signal bool
 	// 8. Not that the transition is complete, the activity should be able to go to sourceV poller.
 	// 9. Set v2 as current again and ensure the wf can complete on it.

-	tv1 := testvars.New(s).WithBuildIDNumber(1)


testvars are coming from env now

stephanos · 2026-05-01T22:11:02Z

 	//        unique namespaces with overrides per namespace should be used for tests that require overrides.
 	defaultDynamicConfigOverrides = map[dynamicconfig.Key]any{
 		dynamicconfig.FrontendRPS.Key():                                         3000,
+		dynamicconfig.FrontendNamespaceReplicationInducingAPIsRPS.Key():         1000,


moved here since it's a global config

stephanos · 2026-05-01T22:27:33Z

+}
+
+func (s *Versioning3Suite) updateUtils() updateutils.UpdateUtils {
+	return updateutils.New(s.T())
 }

 func (s *Versioning3Suite) TestPinnedTask_NoProperPoller() {


"Hide Whitespace is required from here on

stephanos · 2026-05-13T23:27:50Z


 	// create version v1 and make it current
 	idlePollerDone := make(chan struct{})
 	go func() {
-		s.idlePollWorkflow(context.Background(), tv, true, ver3MinPollTime, "should not have gotten any tasks since there are none")


context.Background() should not be used in tests as it is completely unbound

stephanos · 2026-05-13T23:47:50Z

-	ctx, cancel := context.WithTimeout(context.Background(), time.Second*5)
+	ctx, cancel := context.WithTimeout(env.Context(), time.Second*5)
 	defer cancel()


leaving these, though, as they seem to intentionally limit the execution time of these helpers

stephanos force-pushed the stephanos/parallel-versioning branch 4 times, most recently from be92a54 to 7bb6593 Compare May 1, 2026 14:52