Skip to content
This repository was archived by the owner on Apr 19, 2026. It is now read-only.

tfgan_tutorial.ipynb Compatible with TF2.x#20

Open
ayushmankumar7 wants to merge 5 commits into
tensorflow:masterfrom
ayushmankumar7:dev
Open

tfgan_tutorial.ipynb Compatible with TF2.x#20
ayushmankumar7 wants to merge 5 commits into
tensorflow:masterfrom
ayushmankumar7:dev

Conversation

@ayushmankumar7

@ayushmankumar7 ayushmankumar7 commented Feb 27, 2020

Copy link
Copy Markdown

Issue: #18

Code Migrated to TF2.x

@googlebot googlebot added the cla: yes to pull into main branch, I think? label Feb 28, 2020
@ayushmankumar7

ayushmankumar7 commented Mar 2, 2020

Copy link
Copy Markdown
Author

Someone please check this PR

@joel-shor joel-shor self-requested a review March 4, 2020 01:47
@joel-shor joel-shor self-assigned this Mar 4, 2020
@joel-shor

joel-shor commented Mar 4, 2020

Copy link
Copy Markdown
Contributor

This change is good in theory, but I think the same can be achieved by changing the single line "import tensorflow as tf" to "import tensorflow.compat.v1 as tf", which is the preferred way of setting the version. Would you mind doing this instead?

@ayushmankumar7

ayushmankumar7 commented Mar 4, 2020

Copy link
Copy Markdown
Author

No Problem. I ll make the respective changes and commit it.

@ayushmankumar7

ayushmankumar7 commented Mar 4, 2020

Copy link
Copy Markdown
Author

@joel-shor It's done.

@joel-shor

joel-shor commented Mar 8, 2020

Copy link
Copy Markdown
Contributor

I can't review this with all the changes in output causing noise. Can you just change code, not the outputs, so that I can review it? Or else if you hav a suggestion on how to review this without that, please let me know.

joel-shor
joel-shor suggested changes Mar 8, 2020
View reviewed changes

@joel-shor joel-shor left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you leave the output cells the same? The diffs are too large to see the changes otherwise.

@ayushmankumar7

ayushmankumar7 commented Mar 8, 2020

Copy link
Copy Markdown
Author

@joel-shor It's done I have just changed the code. Left the output as it is.

@amit1rrr amit1rrr mentioned this pull request Mar 21, 2020
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@joel-shor joel-shor Awaiting requested review from joel-shor

Assignees

@joel-shor joel-shor

Labels

cla: yes to pull into main branch, I think?

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@ayushmankumar7 @joel-shor @googlebot