feat!: SW-1917 Remove deprecated Drawer and InputOTP components#146
Open
owilliams-tetrascience wants to merge 1 commit into
Open
feat!: SW-1917 Remove deprecated Drawer and InputOTP components#146owilliams-tetrascience wants to merge 1 commit into
owilliams-tetrascience wants to merge 1 commit into
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
owilliams-tetrascience
temporarily deployed
to
artifactory-prod
GitHub Actions
Inactive
Removes the deprecated Drawer and InputOTP components from the library along with their now-unused dependencies. Also relaxes the commitlint subject-case rule so JIRA-key-prefixed subjects (the AGENTS.md convention) are accepted. - Delete drawer.tsx / input-otp.tsx and their stories - Drop public exports from src/index.ts - Remove vaul (Drawer) and input-otp (InputOTP) deps from package.json - Remove both registry.json entries - Update README.md, MIGRATION.md, and DESIGN.md component listings - Disable commitlint subject-case rule to allow "SW-1234" subject prefixes BREAKING CHANGE: Drawer and InputOTP (and their sub-components) are no longer exported from @tetrascience-npm/tetrascience-react-ui. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
owilliams-tetrascience
force-pushed
the
claude/competent-snyder-902315
branch
from
e5c1a73 to
a105988
Compare
owilliams-tetrascience
temporarily deployed
to
artifactory-prod
GitHub Actions
Inactive
Contributor
There was a problem hiding this comment.
Pull request overview
This PR removes the deprecated Drawer and InputOTP UI primitives from @tetrascience-npm/tetrascience-react-ui, along with their now-unneeded dependencies, and updates registry/docs to match the reduced public API surface.
Changes:
- Removed
DrawerandInputOTPcomponents (and their Storybook stories) and dropped their root exports. - Removed
vaulandinput-otpdependencies and regenerated the lockfile accordingly. - Updated
registry.jsonand public documentation (README.md,MIGRATION.md,DESIGN.md) to remove the deleted components from inventories/lists.
Reviewed changes
Copilot reviewed 11 out of 12 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| yarn.lock | Removes vaul / input-otp entries and updates the resolved dependency graph. |
| package.json | Drops vaul and input-otp from dependencies. |
| src/index.ts | Removes public exports for drawer and input-otp. |
| src/components/ui/drawer.tsx | Deletes the deprecated Drawer component implementation. |
| src/components/ui/drawer.stories.tsx | Deletes Storybook stories/play tests for Drawer. |
| src/components/ui/input-otp.tsx | Deletes the deprecated InputOTP component implementation. |
| src/components/ui/input-otp.stories.tsx | Deletes Storybook stories/play tests for InputOTP. |
| registry.json | Removes registry entries for drawer and input-otp. |
| README.md | Updates the UI primitives list to remove Drawer and InputOTP. |
| MIGRATION.md | Removes Drawer / InputOTP from the “New Components” list and removes the vaul dependency mention. |
| DESIGN.md | Updates the component inventory table to remove Drawer and InputOtp. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
owilliams-tetrascience
changed the title
Coverage Report
File CoverageNo changed files found. |
54321jenn-ts
approved these changes
Jun 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Removes the deprecated Drawer and InputOTP components from the UI kit, per SW-1917. Deleting these also lets us drop their dependencies —
vaul(Drawer) andinput-otp(InputOTP), which were each used only by the removed component.drawer.tsx/input-otp.tsxand their storiessrc/index.tsvaulandinput-otpfrompackage.json(lockfile regenerated)registry.jsonentriesREADME.md,MIGRATION.md, andDESIGN.mdcomponent listingssubject-caserule so JIRA-key-prefixed subjects (theAGENTS.mdconvention, e.g.feat: SW-1234 …) are acceptedType of Change
Checklist
yarn lintpassesyarn buildpassesyarn test:allpasses (135 files, 1195 tests)Testing
No Zephyr test cases — both removed components were covered only by their own (now-deleted) stories.
Verification
Notes for reviewer
commitlint.config.jsfix: the defaultsubject-caserule rejected JIRA-key-prefixed subjects (read as start-case), which conflicted with theAGENTS.mdcommit convention. Now disabled sofeat: SW-1234 Descriptionis accepted..agents/skills/shadcn/still mention Drawer/InputOTP as generic shadcn guidance — left untouched since they're third-party reference material, not this library's API surface.grephit for "drawer" (ElevationAndShape.stories.tsx: "Navigation drawers, FABs") is unrelated descriptive text about an elevation level.🤖 Generated with Claude Code