fix(data-app-shell): fix 3 stale Storybook E2E test assertions#151
Draft
Copilot wants to merge 6 commits into
Draft
fix(data-app-shell): fix 3 stale Storybook E2E test assertions#151Copilot wants to merge 6 commits into
Copilot wants to merge 6 commits into
Conversation
Replace the demo breadcrumb trail with generic placeholder labels (All Projects / Project Name / worksession name). Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Add a `navRailHidden` prop to DataAppShell. When true, the desktop icon nav rail is not rendered, so collapsing the sidebar panel can hide both the rail and the panel, giving the content full width. Wired in the Default story to the panel's collapsed state, with a play-test asserting the rail is hidden when collapsed. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Side nav rail (component): - Narrow rail 60px -> 48px; icon-only nav buttons (label moved to aria-label + tooltip); button box 36px -> 30px; glyphs 20px -> 16px. - Remove divider under the app logo; nudge logo up 4px. - Unify breadcrumb text size to text-sm. Workflow step panel (story demo): - Rename demo steps to generic "Step N Name"; drop per-step counts. - Step card height -> 40px; step name uses the text-title-sm token; inactive steps lightened (font-light). - Remove the INPUT/OUTPUT data-count pills and dead helpers. - Add an outline Back button next to Next from step 2 onward. Play-tests updated to query nav buttons by accessible name and the new labels/sizes. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
…to copilot/fix-storybook-e2e-tests
Commit a84f94b narrowed the sidebar rail (60px→48px), made nav buttons icon-only (labels moved to aria-label + tooltip), and removed count pills from WorkflowPanel — but left 3 play-test assertions stale: - WorkflowPanelInteractions: remove getByText("1K") — counts no longer rendered - MultipleNavGroups: use getByRole("button", {name:"Filters"}) instead of getByText("Filters") — nav items are icon-only with aria-label - CompactProperty: change expected rail width "60px" → "48px"
Copilot
AI
changed the title
[WIP] Fix failing GitHub Actions job for Storybook E2E Tests
fix(data-app-shell): fix 3 stale Storybook E2E test assertions
Jun 23, 2026
54321jenn-ts
approved these changes
Jun 23, 2026
Coverage Report
File Coverage
|
||||||||||||||||||||||||||||||||||||||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Commit
a84f94brefactoredDataAppShell(narrowed rail, icon-only nav, dropped count pills) but left 3 play-function assertions untouched, causing the Storybook E2E CI job to fail.Summary
Three stale test assertions in
DataAppShell.stories.tsxare fixed to match the updated component behaviour:getByText("1K"):formatCountand the count-pill rendering were deleted fromWorkflowPanel, so this text no longer exists in the DOM.getAllByText("Filters")/getByText("Filters")withgetByRole("button", { name: "Filters" }): nav items are now icon-only; the label is anaria-label, not visible text.expect(railStyles.width).toBe("60px")→"48px": rail class changed fromw-[60px]tow-12.Type of Change
Checklist
yarn lintpassesyarn buildpassesyarn test:allpassesTesting
SW-T4673, SW-T4677 (Storybook play tests for
MultipleNavGroupsandCompactProperty)Verification
Screenshots
N/A — test-only fix.