fix: SW-2054 correct DataAppShell Storybook E2E test assertions for icon-only rail#155
Draft
Copilot wants to merge 2 commits into
Draft
fix: SW-2054 correct DataAppShell Storybook E2E test assertions for icon-only rail#155Copilot wants to merge 2 commits into
Copilot wants to merge 2 commits into
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
…d counts Three Storybook play-test fixes for PR #138 (feat/dataappshell-rail-style): 1. WorkflowPanelInteractions: remove "1K" count assertion — WorkflowPanel no longer renders inputCount/outputCount pill text. 2. MultipleNavGroups: replace getByText("Filters") / getAllByText("Filters") with getByRole("button", { name: "Filters" }) — nav buttons in the icon rail are now icon-only (label moved to aria-label + tooltip). 3. CompactProperty: update railStyles.width assertion from "60px" to "48px" — rail width changed from w-[60px] to w-12 (48 px).
Copilot
AI
changed the title
[WIP] Fix failing GitHub Actions job for Storybook E2E Tests
fix: SW-2054 correct DataAppShell Storybook E2E test assertions for icon-only rail
Jun 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Three play-test assertions in
DataAppShell.stories.tsxwere not updated to match the component changes landed in PR #138 (icon-only nav rail, removed count display, narrowed rail width), causing the Storybook E2E job to fail.Summary
Root cause: PR #138 changed the DataAppShell component but left three stale test assertions:
getByText("1K")— count pills removed fromWorkflowPanelgetByText("Filters")within the icon rail — labels moved toaria-labelgetByRole("button", { name: "Filters" })railStyles.width==="60px"— rail narrowed fromw-[60px]tow-12"48px"Also carries the component changes from PR #138 (
DataAppShell.tsx: icon-only compact buttons witharia-label,w-12rail, 30px icon box, removed label span).Type of Change
Checklist
yarn lintpassesyarn buildpassesyarn test:allpassesTesting
SW-T4672 (Workflow Panel Interactions), SW-T4673 (Multiple Nav Groups), SW-T4677 (Compact Property)
Verification
Screenshots
N/A — test-only corrections; no visual change beyond what PR #138 already introduced.