Skip to content

Finished! #11

Open
natebcoding wants to merge 16 commits into
the-csharp-academy:masterfrom
natebcoding:master
Open

Finished! #11
natebcoding wants to merge 16 commits into
the-csharp-academy:masterfrom
natebcoding:master

Conversation

@natebcoding

Copy link
Copy Markdown

Mistakingly committed under second account for initial commit. Everything else checks out.

@TheCSharpAcademy TheCSharpAcademy left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@natebcoding Thanks for submitting! This is your third project so we will be a bit more strict. But that's to your benefit. Could you please fix these before we approve?

🔍Validation needs tightening: Quantity allows invalid input to become 0.
Habit name can be empty. Update date does not validate the date. Delete/update accept invalid IDs and do not check whether the record exists first.

🔍 Date format is inconsistent: Create asks for MM/dd/yyyy. Update asks for MM/dd/yy.
Keep one required format and validate it strictly with DateTime.TryParseExact.

🔍I strongly suggest you do the challenges. It's ok to do only the requirements but you will stand out in the industry if you go beyond the basics. There are a lot of useful things to be learned with each challenge.

🔍Repository junk from your commit and leave only the necessary code and readme. Check out the amount of unnecessary files in your project's tree.

Image

🔍The README exists, but it is very brief. Add setup instructions, how to run the app, project requirements, and a short explanation of your thought process.

@natebcoding

Copy link
Copy Markdown
Author

On it 🫡

@natebcoding

Copy link
Copy Markdown
Author

@TheCSharpAcademy Added the required fixes and did the challenges!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants