Skip to content

MathGame Project finished#709

Open
rakenkode wants to merge 1 commit into
the-csharp-academy:mainfrom
rakenkode:main
Open

MathGame Project finished#709
rakenkode wants to merge 1 commit into
the-csharp-academy:mainfrom
rakenkode:main

Conversation

@rakenkode

Copy link
Copy Markdown

Looking forward to getting real feedback from a professional like you. Thanks in advance.

@TheCSharpAcademy

Copy link
Copy Markdown
Collaborator

@rakenkode Project approved! 😄✅ And well done for completing some of the challenges! I recommend you always do that, as it pushes you and makes you learn faster. You also did a great work with the UI and UX, very smooth! 👏

🥋And congratulations! You got your green belt!! 🟩🟩

🔍️Avoid magic numbers. Although _numberOfQuestions exists, the value 5 is still hardcoded in several places (if (_questionNumber < 5), "GAME X of 5", if (_questionNumber == 5)). Use _numberOfQuestions consistently instead.

🔍️Question contains two overloads of CreateProblems(), but only the GameType version is required. The CreateProblems(int mode) overload appears to be unused and should be removed to keep the codebase clean.

🔍️Every Question creates its own Random instance, and Thread.Sleep() is used to try to avoid duplicate seeds. This is generally considered a bad practice. Instead, use a single shared Random instance (or Random.Shared in modern .NET) and remove the Thread.Sleep() calls entirely.

👪Oh and if possible join our Discord Community and add your username to your profile so you can be part of the community as well. 😁 And do you mind adding a country in your profile as well? The dashboard and leaderboard look neater when there's a flag. If you're not comfortable with that you can submit a random country.

✋🏻Looking forward to seeing your next projects!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants