Skip to content

Release Opcore 0.2.0: npm 11 publish repair #232

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
tomdps merged 3 commits into from
Jul 13, 2026
Merged

Release Opcore 0.2.0: npm 11 publish repair #232

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
2c74203
fix(release): parse npm 11 pack output
tomdps Jul 13, 2026
9395921
Merge pull request #231 from the-open-engine/codex/fix-release-publis…
tomdps Jul 13, 2026
34a8c2c
Merge branch 'main' into dev
tomdps Jul 13, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions scripts/release-dry-run.mjs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ import {
graphCoreSupportedTargets
} from "./graph-native-targets.mjs";
import { publicReleasePackageNames, releasePackageDirForName } from "./release-package-dirs.mjs";
import { createStagedOpcorePackage } from "./stage-opcore-bundle.mjs";
import { createStagedOpcorePackage, npmPackResultForPackage } from "./stage-opcore-bundle.mjs";

const releaseVersion = "0.2.0";
const publicPackages = publicReleasePackageNames;
Expand Down Expand Up @@ -87,7 +87,8 @@ function packWorkspace(packageName, destination) {
const result = run("npm", ["pack", "--json", "--pack-destination", destination], {
cwd: staged?.packageDir ?? releasePackageDirForName(packageName)
});
const parsed = JSON.parse(result.stdout)[0];
const parsed = npmPackResultForPackage(JSON.parse(result.stdout), packageName);
if (!parsed) throw new Error(`${packageName} npm pack returned no package result:\n${result.stdout}`);
if (parsed.version !== releaseVersion) throw new Error(`${packageName} packed version ${parsed.version}, expected ${releaseVersion}`);
return join(destination, parsed.filename);
} finally {
Expand Down
4 changes: 4 additions & 0 deletions tests/native-packaging-policy.test.mjs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,6 +53,10 @@ describe("native graph-core packaging policy", () => {
assert.match(stageBundle, /"pack", "\.", "--dry-run", "--json", "--ignore-scripts"/);
assert.match(stageBundle, /disableLifecycleScripts: true/);
assert.match(stageBundle, /delete manifest\.scripts/);

const releaseDryRun = readFileSync("scripts/release-dry-run.mjs", "utf8");
assert.match(releaseDryRun, /npmPackResultForPackage\(JSON\.parse\(result\.stdout\), packageName\)/);
assert.doesNotMatch(releaseDryRun, /JSON\.parse\(result\.stdout\)\[0\]/);
});

it("encodes npm os/cpu support in each bundled native package manifest", () => {
Expand Down
Loading