Repository navigation
Coordinates.svg: the panel only, without title and legend - #25
Merged
Merged
Conversation
On GitHub the README said everything in the picture's title and legend again right below it, and the picture shrank to about 80 % of its 1180 pixels, so its text was barely readable. It now shows the panel only, with setColumn(5, value) and setRow(2, 2, value) written under what they set, and is 324 pixels high instead of 430. DocuSvg takes the coordinate its picture starts at, so that the coordinate picture shares the layout of the wiring pictures without their title. The wiring pictures keep their legend, since nothing explains them next to it, and lose the space a third legend line had needed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On GitHub the picture's title and legend said what the README says right below it. The picture is 1180 px wide and was shown at about 80 %, so its text was barely readable.
Coordinates.svgshows the panel only.setColumn(5, value)andsetRow(2, 2, value)are written in their colour under what they set, so the picture still reads on its own. It is 324 px high instead of 430.DocuSvgtakes the coordinate a picture starts at (theviewBoxorigin), so the coordinate picture keeps the layout of the wiring pictures without drawing their title.210 tests pass,
docu/picturesincluded. Both pictures rendered with resvg and looked at.