Skip to content

Fix zombie task on deployment#1255

Merged
gyoge0 merged 1 commit into
devfrom
fix-deployment
May 27, 2026
Merged

Fix zombie task on deployment#1255
gyoge0 merged 1 commit into
devfrom
fix-deployment

Conversation

@jackrhoa

@jackrhoa jackrhoa commented May 27, 2026

Copy link
Copy Markdown
Collaborator

What I did

  • Fixed release task creation
  • Prev version was appending arguments and release task was treated as normal task and never exited

Testing

Run these commands locally

docker build -t tcf-test .
docker run --rm tcf-test bash -c "echo 'release task would run here; exiting cleanly'"
  • With ENTRYPOINT, it hangs
  • With CMD, it exits as expected

Summary by CodeRabbit

  • Chores
    • Updated Docker container startup configuration
    • Added port 80 exposure declaration to Docker image configuration

Review Change Stack

@jackrhoa jackrhoa requested a review from gyoge0 May 27, 2026 15:06
@jackrhoa jackrhoa self-assigned this May 27, 2026
@coderabbitai

coderabbitai Bot commented May 27, 2026

Copy link
Copy Markdown
Contributor

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 7be43226-0f14-4caf-a05a-a1e401458198

📥 Commits

Reviewing files that changed from the base of the PR and between 409b864 and a19656e.

📒 Files selected for processing (1)
  • Dockerfile

📝 Walkthrough

Walkthrough

The Dockerfile container startup configuration was updated to expose port 80 and switch the startup method from ENTRYPOINT to CMD for the /app/scripts/container-startup.sh script.

Changes

Container Startup Configuration

Layer / File(s) Summary
Port exposure and startup command
Dockerfile
EXPOSE 80 instruction added to declare port 80 accessibility. Container startup mechanism changed from ENTRYPOINT to CMD for /app/scripts/container-startup.sh, allowing override of the startup script.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Poem

A rabbit hops to Docker's door,
Port eighty's now exposed once more,
CMD replaces ENTRYPOINT's chain,
Containers start with gentle reign. 🐰

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title 'Fix zombie task on deployment' accurately describes the main change: switching from ENTRYPOINT to CMD to prevent processes from hanging after the startup script completes.
Description check ✅ Passed The description covers 'What I did' with implementation details and 'Testing' with clear reproduction steps, but lacks the 'GitHub Issues addressed' section from the template.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix-deployment

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@gyoge0 gyoge0 merged commit 3fd24b1 into dev May 27, 2026
6 checks passed
@jackrhoa jackrhoa deleted the fix-deployment branch May 28, 2026 15:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants