Fix /x/worker/ page broken by generic type params in MDX#1142
Merged
Conversation
commit: |
jbolda
approved these changes
Mar 22, 2026
cowboyd
reviewed
Mar 25, 2026
Member
cowboyd
left a comment
cowboyd
left a comment
There was a problem hiding this comment.
Looks good to me. One thing though: Can you ask Claude not to market itself by adding itself to commits and PRs?
JSDoc comments containing generic type references like `Result<T>` were being interpreted as JSX tags by MDX, causing the worker extension page to fail with a parse error. Escape uppercase-starting angle bracket patterns to HTML entities before MDX processing.
taras
force-pushed
the
fix/escape-generic-type-params-in-mdx
branch
from
9f37d80 to
c150da7
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
/x/worker/page was failing with "Failed to load worker due to error" because MDX interpreted generic type references likeResult<T>in JSDoc comments as JSX tagsuseMarkdownto escape uppercase-starting angle bracket patterns (e.g.<T>,<TSend, TRecv>) to HTML entities before MDX processingTest plan
/x/worker/renders correctly with README + API reference (155KB vs 13KB error page)/x/fetch/,/x/websocket/,/x/process/still render correctly