Repository navigation
/models files security audit and fixes and query update - #3136
Open
Anindra123 wants to merge 40 commits into
Open
Anindra123 wants to merge 40 commits into
Anindra123 wants to merge 40 commits into
Conversation
`UserModel.php` Fix: typcast to int before placing it in string interpolation for query
Fix: Query hardened for the several model class
`QuizModel.php` : Security Fixes
/models files security audit and fixes and query update
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ClickUp ticket link:
https://app.clickup.com/t/9018365849/z8zyy1pz6b
Description
Found out vulnerabilities for classes in models/ folder
Updated classes in models folder to use new fluent DB query instead of QueryHelper
Added unit tests for several model classes
QuizModel.phpABSPATHcheckget_quiz_answers_by_attempt_idtheattempt_idwas not type casted to int, further more there was no prepare statement on the queryget_quiz_attempt_timing@unserialize was calling with error suppressed with no proper flag passed to prevent PHP object injectionget_quiz_count_by_coursethe query was updated to use query helper insteadCourseModel.phpget_coursesadded check for excludes id array and post status parameter and used prepare in clausemanage_optionsinstead ofadministratorEnrollmentModel.phpget_enrolled_dataadded check for status and course id post typeOrderModel.phpcreate_orderafter catch no rollback query was runningget_refunds_by_userthe $user_id was placed with direct interpolation with no prepare query checkTesting
Use of AI Tool
Used: Yes
Used for:
Finding security issues on all the classes in models/