fix: incorrect content-length value in headers#10
Open
oxyflour wants to merge 1 commit into
Open
Conversation
This fix "socket hang up" issue when I'm trying to send contents including Chinese characters
Owner
|
Awesome 😊. Can you explain the change from property to e:property in your first commit ? Thanks ! |
Author
|
Oh, that was an accident. I should not have pushed that commit :-) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello! This PR fixes "socket hang up" issue when I'm trying to send contents including Chinese characters. The "content-length" should be the byte length of the buffer rather than the string length, or the remote server may close the connection too early and truncate the posting content unexpectedly.