refactor: update SPI pin definitions for ESP32S3 target#7
Open
gnahiak2 wants to merge 4 commits into
Open
Conversation
There was a problem hiding this comment.
Pull request overview
Note
Copilot was unable to run its full agentic suite in this review.
Updates ESP32-S3 SPI pin assignments and removes the local devcontainer setup for the serprog project.
Changes:
- Remap ESP32-S3 SPI pin defines for the EEPROM/SPI bus.
- Remove
.devcontainer/devcontainer.jsonconfiguration. - Remove
.devcontainer/Dockerfilecontainer build used for ESP-IDF/QEMU dev environment.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
src/serprog/main/main.c |
Changes hardcoded ESP32-S3 SPI pin mappings. |
src/serprog/.devcontainer/devcontainer.json |
Removes VS Code/Codespaces devcontainer configuration. |
src/serprog/.devcontainer/Dockerfile |
Removes the container image definition (ESP-IDF + QEMU tooling). |
Comments suppressed due to low confidence (2)
src/serprog/.devcontainer/devcontainer.json:1
- Removing the devcontainer configuration drops a reproducible dev environment (VS Code/Codespaces settings, ESP-IDF paths, required extensions). If the project still expects container-based development, consider replacing it with a minimal/updated devcontainer (or moving it to the repo root if that’s the new convention) and adding a short note in developer docs indicating the supported workflow.
src/serprog/.devcontainer/Dockerfile:1 - This removal also eliminates the pinned ESP-IDF base image + QEMU toolchain setup used for local emulation (and potentially for onboarding/CI if anyone relied on it). If containerization is being intentionally discontinued, consider adding an alternative (e.g., documented host prerequisites or a new container definition elsewhere) to avoid breaking established workflows.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
34
to
+39
| #elif defined CONFIG_IDF_TARGET_ESP32S3 | ||
| #define EEPROM_HOST SPI2_HOST | ||
| #define PIN_NUM_MISO 5 | ||
| #define PIN_NUM_MOSI 16 | ||
| #define PIN_NUM_CLK 15 | ||
| #define PIN_NUM_CS 4 | ||
| #define PIN_NUM_MISO 13 | ||
| #define PIN_NUM_MOSI 11 | ||
| #define PIN_NUM_CLK 12 | ||
| #define PIN_NUM_CS 10 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.