Add the option of setting RUNTIME in the Conundrum build script#6
Open
Zawaken wants to merge 2 commits intothockco:masterfrom
Open
Add the option of setting RUNTIME in the Conundrum build script#6Zawaken wants to merge 2 commits intothockco:masterfrom
Zawaken wants to merge 2 commits intothockco:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The part regarding the runtime is mostly just copy pasted from the docker_build.sh script in qmk_firmware
Description
Modified
build-conundrum.shto check if podman or docker container runtime exists on the machine, and pick the first it finds, and if none are found, error out.Also added the possibility of using a commandline argument instead of environment variable to supply the custom keymap name.
Types of Changes
Issues Fixed or Closed by This PR
Checklist