[Snyk] Security upgrade @thoughtspot/ts-chart-sdk from 0.0.2-alpha.3 to 1.0.0#212
[Snyk] Security upgrade @thoughtspot/ts-chart-sdk from 0.0.2-alpha.3 to 1.0.0#212
Conversation
…et-chart/package-lock.json to reduce vulnerabilities The following vulnerabilities are fixed with an upgrade: - https://snyk.io/vuln/SNYK-JS-ROLLUP-15340920
|
Minimum allowed coverage is Generated by 🐒 cobertura-action against 14eec5a |
| }, | ||
| "dependencies": { | ||
| "@thoughtspot/ts-chart-sdk": "^0.0.2-alpha.3", | ||
| "@thoughtspot/ts-chart-sdk": "^1.0.0", |
There was a problem hiding this comment.
🚨 Critical Version Mismatch
This upgrade creates a severe version inconsistency:
- This example: Upgrading to
^1.0.0 - Main SDK package: Currently at
2.9.2 - Other examples: Using
2.7.6
Issues:
- The example will be using an outdated major version (1.0.0) while the current SDK is at 2.9.2
- This creates compatibility issues and misleading developer experience
- May not work with current ThoughtSpot platform features
Recommendation:
Change to "^2.9.2" to match the current SDK version, or verify that 1.0.0 is truly the correct target version for this security fix.
| @@ -8,7 +8,7 @@ | |||
| "name": "custom-leaflet-chart", | |||
| "version": "0.0.1", | |||
| "dependencies": { | |||
There was a problem hiding this comment.
📋 Missing Test Coverage & Security Concerns
This SDK upgrade introduces several concerns:
1. Test Coverage Gap:
- This example has zero test coverage despite being upgraded to a major new version
- The security fix should have regression tests to prevent future vulnerabilities
2. Security Dependencies:
- New dependency
cldr-dataincludes install scripts that should be reviewed - Multiple new dependencies increase attack surface
Recommendation:
- Add basic functionality tests for this example
- Review install scripts in new dependencies for security implications
Security Upgrade Review SummaryStatus: ❌ NOT READY TO MERGE - Critical issues must be resolved 🚨 Critical Issues1. Major Version Mismatch
2. Example Version Inconsistency
|
Snyk has created this PR to fix 1 vulnerabilities in the npm dependencies of this project.
Snyk changed the following file(s):
example/custom-leaflet-chart/package.jsonexample/custom-leaflet-chart/package-lock.jsonVulnerabilities that will be fixed with an upgrade:
SNYK-JS-ROLLUP-15340920
Important
Note: You are seeing this because you or someone else with access to this repository has authorized Snyk to open fix PRs.
For more information:
🧐 View latest project report
📜 Customise PR templates
🛠 Adjust project settings
📚 Read about Snyk's upgrade logic
Learn how to fix vulnerabilities with free interactive lessons:
🦉 Directory Traversal