[Snyk] Security upgrade eslint from 8.42.0 to 9.0.0#219
Conversation
The following vulnerabilities are fixed with an upgrade: - https://snyk.io/vuln/SNYK-JS-FLATTED-15518041
|
Minimum allowed coverage is Generated by 🐒 cobertura-action against c927071 |
| "@vitejs/plugin-react": "^4.0.0", | ||
| "autoprefixer": "^10.4.14", | ||
| "eslint": "^8.38.0", | ||
| "eslint": "^9.0.0", |
There was a problem hiding this comment.
-
Plugin Incompatibility:
@typescript-eslint/parserv5.59.0 is incompatible with ESLint v9. You need to upgrade to@typescript-eslint/parser: "^7.0.0"for ESLint v9 compatibility. -
Configuration Breaking Change: ESLint v9 deprecates
.eslintrc.*files in favor of flat config (eslint.config.js). The current.eslintrc.cjswill generate warnings/errors. -
Missing CI Coverage: The playground app's linting isn't tested in CI, so this breaking change won't be caught by automated testing.
Recommendation: Either:
- Revert this change and coordinate a proper migration with all plugin updates
- Or update all related TypeScript ESLint plugins and migrate to flat config format
PR Review SummaryThis PR upgrades ESLint from v8.38.0 to v9.0.0 in the playground app, but introduces critical compatibility issues that make it NOT READY TO MERGE. Critical Issues Found:
Required Actions Before Merge:
Review Status:
Verdict: This PR requires significant additional work before it's safe to merge. Consider coordinating a comprehensive ESLint v9 migration rather than this isolated upgrade. |
Snyk has created this PR to fix 1 vulnerabilities in the pnpm dependencies of this project.
Snyk changed the following file(s):
playground/app/package.jsonVulnerabilities that will be fixed with an upgrade:
SNYK-JS-FLATTED-15518041
Important
Note: You are seeing this because you or someone else with access to this repository has authorized Snyk to open fix PRs.
For more information:
🧐 View latest project report
📜 Customise PR templates
🛠 Adjust project settings
📚 Read about Snyk's upgrade logic
Learn how to fix vulnerabilities with free interactive lessons:
🦉 Learn about vulnerability in an interactive lesson of Snyk Learn.