Skip to content

SCAL-304516 isRendered set sync#502

Open
yinstardev wants to merge 1 commit intomainfrom
SCAL-304516-isrendered
Open

SCAL-304516 isRendered set sync#502
yinstardev wants to merge 1 commit intomainfrom
SCAL-304516-isrendered

Conversation

@yinstardev
Copy link
Copy Markdown
Contributor

No description provided.

@yinstardev yinstardev requested a review from a team as a code owner April 8, 2026 23:44
@sonar-prod-ts
Copy link
Copy Markdown

sonar-prod-ts bot commented Apr 8, 2026

SonarQube Quality Gate

Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request modifies the render method in the TsEmbed class to set the isRendered flag to true before awaiting the isReadyForRenderPromise. I have no feedback to provide.

@pkg-pr-new
Copy link
Copy Markdown

pkg-pr-new bot commented Apr 8, 2026

Open in StackBlitz

npm i https://pkg.pr.new/@thoughtspot/visual-embed-sdk@502

commit: 9897624

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant