Skip to content

added changes for file upload handling#503

Open
singhkaramveer012 wants to merge 3 commits intomainfrom
SCAL-299515
Open

added changes for file upload handling#503
singhkaramveer012 wants to merge 3 commits intomainfrom
SCAL-299515

Conversation

@singhkaramveer012
Copy link
Copy Markdown
Collaborator

No description provided.

@singhkaramveer012 singhkaramveer012 requested a review from a team as a code owner April 9, 2026 07:51
@pkg-pr-new
Copy link
Copy Markdown

pkg-pr-new bot commented Apr 9, 2026

Open in StackBlitz

npm i https://pkg.pr.new/@thoughtspot/visual-embed-sdk@503

commit: 50043c8

@gemini-code-assist
Copy link
Copy Markdown
Contributor

Warning

Gemini is experiencing higher than usual traffic and was unable to create the review. Please try again in a few hours by commenting /gemini review.

animesh935
animesh935 previously approved these changes Apr 13, 2026
@shivam-kumar-ts
Copy link
Copy Markdown
Contributor

/gemini review

Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request adds support for file uploads in the Spotter chat interface across AppEmbed, SpotterEmbed, and LiveboardEmbed. It introduces the spotterFileUploadEnabled and spotterFileUploadFileTypes configuration options, updates the URL parameter generation logic, and adds corresponding unit tests. I have no feedback to provide.

@sonar-prod-ts
Copy link
Copy Markdown

sonar-prod-ts bot commented Apr 13, 2026

SonarQube Quality Gate

Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 2 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants