[SCAL-303326] support visual overrides for charts#505
[SCAL-303326] support visual overrides for charts#505rijadrahim wants to merge 7 commits intomainfrom
Conversation
There was a problem hiding this comment.
Code Review
This pull request introduces the VisualOverridesPayload interface and integrates it into the AppEmbed, SearchEmbed, and Conversation components to allow for visual customization of charts and tables. Key changes include updating view configurations and initialization data logic to support visualOverridesParams. Review feedback identifies that the @version tags added to the new properties in app.ts and search.ts do not follow the required format of including both the SDK and ThoughtSpot Cloud versions as specified in the repository style guide.
I am having trouble creating individual review comments. Click here to see my feedback.
src/embed/app.ts (784)
The @version tag is incomplete. According to the repository style guide (lines 55, 106), it should include both the SDK and ThoughtSpot Cloud versions in the format @version SDK: X.Y.Z | ThoughtSpot Cloud: A.B.C.cl. Please add the corresponding ThoughtSpot Cloud version for SDK 1.47.0.
References
- The
@versiontag must be in the formatSDK: X.Y.Z | ThoughtSpot Cloud: A.B.C.cl. (link)
src/embed/search.ts (325)
The @version tag is incomplete. According to the repository style guide (lines 55, 106), it should include both the SDK and ThoughtSpot Cloud versions in the format @version SDK: X.Y.Z | ThoughtSpot Cloud: A.B.C.cl. Please add the corresponding ThoughtSpot Cloud version for SDK 1.47.0.
References
- The
@versiontag must be in the formatSDK: X.Y.Z | ThoughtSpot Cloud: A.B.C.cl. (link)
commit: |
|
SonarQube Quality Gate
|








No description provided.