Skip to content

[SCAL-303326] support visual overrides for charts#505

Open
rijadrahim wants to merge 7 commits intomainfrom
SCAL-303326
Open

[SCAL-303326] support visual overrides for charts#505
rijadrahim wants to merge 7 commits intomainfrom
SCAL-303326

Conversation

@rijadrahim
Copy link
Copy Markdown
Contributor

No description provided.

@rijadrahim rijadrahim requested a review from a team as a code owner April 10, 2026 03:02
Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces the VisualOverridesPayload interface and integrates it into the AppEmbed, SearchEmbed, and Conversation components to allow for visual customization of charts and tables. Key changes include updating view configurations and initialization data logic to support visualOverridesParams. Review feedback identifies that the @version tags added to the new properties in app.ts and search.ts do not follow the required format of including both the SDK and ThoughtSpot Cloud versions as specified in the repository style guide.

I am having trouble creating individual review comments. Click here to see my feedback.

src/embed/app.ts (784)

medium

The @version tag is incomplete. According to the repository style guide (lines 55, 106), it should include both the SDK and ThoughtSpot Cloud versions in the format @version SDK: X.Y.Z | ThoughtSpot Cloud: A.B.C.cl. Please add the corresponding ThoughtSpot Cloud version for SDK 1.47.0.

References
  1. The @version tag must be in the format SDK: X.Y.Z | ThoughtSpot Cloud: A.B.C.cl. (link)

src/embed/search.ts (325)

medium

The @version tag is incomplete. According to the repository style guide (lines 55, 106), it should include both the SDK and ThoughtSpot Cloud versions in the format @version SDK: X.Y.Z | ThoughtSpot Cloud: A.B.C.cl. Please add the corresponding ThoughtSpot Cloud version for SDK 1.47.0.

References
  1. The @version tag must be in the format SDK: X.Y.Z | ThoughtSpot Cloud: A.B.C.cl. (link)

@pkg-pr-new
Copy link
Copy Markdown

pkg-pr-new bot commented Apr 10, 2026

Open in StackBlitz

npm i https://pkg.pr.new/@thoughtspot/visual-embed-sdk@505

commit: cc24920

@sonar-prod-ts
Copy link
Copy Markdown

sonar-prod-ts bot commented Apr 13, 2026

SonarQube Quality Gate

Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants