Skip to content

SCAL-306867: Implement Access Token parsing from url param in Embed SDK#506

Merged
saikumar-anapuram merged 2 commits into
mainfrom
SCAL-306867
Apr 27, 2026
Merged

SCAL-306867: Implement Access Token parsing from url param in Embed SDK#506
saikumar-anapuram merged 2 commits into
mainfrom
SCAL-306867

Conversation

@saikumar-anapuram
Copy link
Copy Markdown
Collaborator

No description provided.

@saikumar-anapuram saikumar-anapuram self-assigned this Apr 16, 2026
@saikumar-anapuram saikumar-anapuram requested a review from a team as a code owner April 16, 2026 01:10
@snyk-io
Copy link
Copy Markdown
Contributor

snyk-io Bot commented Apr 16, 2026

Snyk checks have passed. No issues have been found so far.

Status Scan Engine Critical High Medium Low Total (0)
Open Source Security 0 0 0 0 0 issues
Licenses 0 0 0 0 0 issues
Code Security 0 0 0 0 0 issues

💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse.

Comment thread src/tokenizedFetch.ts Outdated
Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces a mechanism to cache and reuse authentication tokens for SAML popup flows, reducing redundant login checks. It also updates the tokenizedFetch utility to include these cached tokens in the Authorization header for non-cookieless authentication types. However, a regression was identified in tokenizedFetch where the credentials: 'include' setting is omitted when a cached token is used, which will prevent session cookies from being sent. Additionally, it is recommended to centralize the hardcoded 'cachedAuthToken' key to improve maintainability.

Comment thread src/tokenizedFetch.ts Outdated
Comment thread src/auth.ts Outdated
@pkg-pr-new
Copy link
Copy Markdown

pkg-pr-new Bot commented Apr 16, 2026

Open in StackBlitz

npm i https://pkg.pr.new/@thoughtspot/visual-embed-sdk@506

commit: bfae2f7

Comment thread src/auth.ts Outdated
Comment thread src/auth.ts Outdated
ruchI9897
ruchI9897 previously approved these changes Apr 20, 2026
Copy link
Copy Markdown
Contributor

@ruchI9897 ruchI9897 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Comment thread src/tokenizedFetch.ts Outdated
@sonar-prod-ts
Copy link
Copy Markdown

sonar-prod-ts Bot commented Apr 26, 2026

SonarQube Quality Gate

Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 2 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@saikumar-anapuram saikumar-anapuram merged commit 8efb1ea into main Apr 27, 2026
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants