Skip to content

[SCAL-307754] added type for AxisMenu Merge and Compare#512

Merged
rijadrahim merged 1 commit into
mainfrom
SCAL-307754
Apr 27, 2026
Merged

[SCAL-307754] added type for AxisMenu Merge and Compare#512
rijadrahim merged 1 commit into
mainfrom
SCAL-307754

Conversation

@rijadrahim
Copy link
Copy Markdown
Contributor

No description provided.

@rijadrahim rijadrahim requested a review from a team as a code owner April 22, 2026 08:42
@pkg-pr-new
Copy link
Copy Markdown

pkg-pr-new Bot commented Apr 22, 2026

Open in StackBlitz

npm i https://pkg.pr.new/@thoughtspot/visual-embed-sdk@512

commit: 160e0b0

Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request adds two new enum members, AxisMenuCompare and AxisMenuMerge, to the Action enum in src/types.ts to support chart axis customization features. The review feedback points out that the JSDoc documentation for both new members violates the repository style guide regarding tag ordering and formatting. Specifically, the @Version tag should appear before the @example tag, and a stray asterisk before the @Version tag needs to be removed.

Comment thread src/types.ts Outdated
Comment thread src/types.ts Outdated
@sonar-prod-ts
Copy link
Copy Markdown

sonar-prod-ts Bot commented Apr 22, 2026

SonarQube Quality Gate

Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@rijadrahim rijadrahim merged commit ab697a2 into main Apr 27, 2026
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants