WebGLState: Add getParameter and pixelStorei#2204
Merged
Methuselah96 merged 2 commits intoJun 16, 2026
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With r184 the
WebGLStateclass gained two new methods as part of mrdoob/three.js#33227. These are accessible through the renderer (renderer.state) and are thus part of the public API. This PR adds bothpixelStoreiandgetParameterto theWebGLState.d.tsfile.Both methods are effectively wrappers for the corresponding ones in
WebGLRenderingContext. I've based the parameter and return types on the ones used inlib.dom.d.tsbut kept the names as they appear in the Three.js source code.