Skip to content

bugfix: Line thread safety#7

Merged
babolivier merged 6 commits into
thunderbird:mainfrom
MooseTheRebel:bugfix/line-thread-safety
Apr 23, 2026
Merged

bugfix: Line thread safety#7
babolivier merged 6 commits into
thunderbird:mainfrom
MooseTheRebel:bugfix/line-thread-safety

Conversation

@MooseTheRebel
Copy link
Copy Markdown
Contributor

@MooseTheRebel MooseTheRebel commented Apr 17, 2026

Fixes #2

@MooseTheRebel
Copy link
Copy Markdown
Contributor Author

@babolivier I'm not saying that this PR is ready for review (so I still have it marked as a draft), but would you be willing to approve the CI workflow?

I'm still (VERY) novice at Rust, so I'm just looking to dip my toe in.

@babolivier
Copy link
Copy Markdown
Member

babolivier commented Apr 20, 2026

Sure thing! I've taken a very brief look at the code changes to make sure it would be fine to do so, and I've just triggered it 🙂

@MooseTheRebel MooseTheRebel marked this pull request as ready for review April 21, 2026 11:16
@MooseTheRebel MooseTheRebel requested a review from a team as a code owner April 21, 2026 11:16
@MooseTheRebel
Copy link
Copy Markdown
Contributor Author

Hi @babolivier , sorry for the slow reply.

Since all checks passed, I think it is safe to mark this PR as ready for review 👍

I'm experimenting locally still trying to understand a bit more about threading in Rust, and I have another test that I feel good about, but a 3rd test which confuses me a bit.

Anyhow, I'll leave this PR alone (as-is) so that you can review it, and just watch to see your feedback.

Thank you! 🙇

Copy link
Copy Markdown
Member

@babolivier babolivier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR looks great to me, thanks a lot for working on it! I was also able to hack a test (in a fairly ugly way) to confirm it works over multiple threads, and I've confirmed this doesn't break anything when used in Thunderbird.

I've just got a small request regarding the dependency in Cargo.toml but I'll be happy to merge once this is addressed.

I'm experimenting locally still trying to understand a bit more about threading in Rust, and I have another test that I feel good about, but a 3rd test which confuses me a bit.

Let me know if you need any support moving forward, either in here or on Matrix (we have a room for Thunderbird-adjacent Rust development here: #tb-oxidization:mozilla.org)! I'd be more than happy to help 🙂

Comment thread Cargo.toml Outdated
Copy link
Copy Markdown
Member

@babolivier babolivier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! Let's get this merged now, if testing improvements come up we can figure it out in a follow-up PR.

@babolivier babolivier merged commit 85b7f75 into thunderbird:main Apr 23, 2026
1 check passed
@MooseTheRebel MooseTheRebel deleted the bugfix/line-thread-safety branch April 23, 2026 21:26
@MooseTheRebel
Copy link
Copy Markdown
Contributor Author

Thank you @babolivier , and thank you for the Matrix invite! I'll try to join at some point soon 🙂

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Make Line thread-safe

2 participants