bugfix: Line thread safety#7
Conversation
|
@babolivier I'm not saying that this PR is ready for review (so I still have it marked as a draft), but would you be willing to approve the CI workflow? I'm still (VERY) novice at Rust, so I'm just looking to dip my toe in. |
|
Sure thing! I've taken a very brief look at the code changes to make sure it would be fine to do so, and I've just triggered it 🙂 |
|
Hi @babolivier , sorry for the slow reply. Since all checks passed, I think it is safe to mark this PR as ready for review 👍 I'm experimenting locally still trying to understand a bit more about threading in Rust, and I have another test that I feel good about, but a 3rd test which confuses me a bit. Anyhow, I'll leave this PR alone (as-is) so that you can review it, and just watch to see your feedback. Thank you! 🙇 |
babolivier
left a comment
There was a problem hiding this comment.
This PR looks great to me, thanks a lot for working on it! I was also able to hack a test (in a fairly ugly way) to confirm it works over multiple threads, and I've confirmed this doesn't break anything when used in Thunderbird.
I've just got a small request regarding the dependency in Cargo.toml but I'll be happy to merge once this is addressed.
I'm experimenting locally still trying to understand a bit more about threading in Rust, and I have another test that I feel good about, but a 3rd test which confuses me a bit.
Let me know if you need any support moving forward, either in here or on Matrix (we have a room for Thunderbird-adjacent Rust development here: #tb-oxidization:mozilla.org)! I'd be more than happy to help 🙂
babolivier
left a comment
There was a problem hiding this comment.
Thank you! Let's get this merged now, if testing improvements come up we can figure it out in a follow-up PR.
|
Thank you @babolivier , and thank you for the Matrix invite! I'll try to join at some point soon 🙂 |
Fixes #2