You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Saw the bustage, sorry for not noticing this should have been a major version bump. Not sure what we should do now, since it's already shipped, but someone who marks the dependency as 1 could have two different expected APIs.
It's also my mistake for not realising the change broke API stability.
someone who marks the dependency as 1 could have two different expected APIs
Unless they've pinned 1.0.0 (with =1.0.0), I'd expect Cargo should always pick 1.1.0, so there's some stability there. The crate's only been out for a little amount of time so hopefully nobody besides us has actually started to consume it, so I think we should just make sure we keep >=1.1.0 stable (we could yank the release from crates.io, but I'm not convinced it's worth the pain considering the circumstances).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.