Vite, TypeScript and ESLint updates and housekeeping#274
Open
devmount wants to merge 5 commits into
Open
Conversation
Contributor
davinotdavid
left a comment
There was a problem hiding this comment.
Commenting only for now as I am not super familiar with the history / reason of our configs.
I think I need to read a bit more about the tsconfig / vite config options as I am not entirely sure why we need all the config we currently use but also running npm run build outputs this in my machine:
❯ npm run build
> @thunderbirdops/services-ui@1.6.2 build
> vite build --
vite v8.0.11 building client environment for production...
✓ 126 modules transformed.
[unplugin:dts] Start generate declaration files...
[unplugin:dts] Start bundling declaration files...
[unplugin:dts] Failed to load '@microsoft/api-extractor', have you installed it?
[unplugin:dts] Error occurred, skip bundle declaration files.
[unplugin:dts] Declaration files built in 1089ms.
I seems to still produce an output but again I wonder if we can simplify our setup further so we can have more smoother dependency package updates in the future.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed?
This change maintains package dependencies. In particular, the following packages got a major upgrade:
Viteto v8TypeScriptto v6ESLintto v10All other packages got minor or patch updates.
eslint-plugin-importgot removed (imho not needed anymore and incompatible to ES 10).Furthermore, the
tsconfig*files were changed to their common default values for migration purposes to TS 6. Please review that carefully and let me know, if I missed something here.Also type errors were fixed and linting issues. All changes were kept at minor level, no breaking change was introduced intentionally.
All changes were tested. Linting, Building and Storybook work as intended locally for me. But please test and confirm this.
Applicable Issues
Fixes https://github.com/thunderbird/services-ui/security/dependabot/54, https://github.com/thunderbird/services-ui/security/dependabot/55 and https://github.com/thunderbird/services-ui/security/dependabot/56
Closes #273