fix(#701): disable telemetry by default for self-hosted (OIDC) instances#714
Open
rbalogic wants to merge 14 commits into
Open
fix(#701): disable telemetry by default for self-hosted (OIDC) instances#714rbalogic wants to merge 14 commits into
rbalogic wants to merge 14 commits into
Conversation
216ed9c to
909efc5
Compare
909efc5 to
a761452
Compare
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
Reviewed by Cursor Bugbot for commit a761452. Configure here.
- centralize data collection default on isOidcMode - update default helper tests to mock the auth mode utility
- centralize data collection default on isOidcMode - update default helper tests to mock the auth mode utility
f554cd4 to
fc18196
Compare
Member
|
Hey @rbalogic thanks so much for this PR! Really appreciate the contribution. I'd love to see this get merged if you want to make a few adjustments:
|
…logic/thunderbolt into fix/701-disable-telemetry-by-default
Author
|
@cjroth Thanks for the feedback! 🙌 I’ve implemented the requested changes:
Please take another look when you have a moment—happy to iterate further or make any additional tweaks before merge. Thanks again for the guidance! |
Author
|
@cjroth Please review the changes when you can, Thanks. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

This PR updates the default settings for data collection to be opt-in rather than opt-out for self-hosted/enterprise environments.
Changes:
getDefaultDataCollectionValueinsrc/defaults/settings.tsto manage the default-value logic.isOidcMode()utility from@/lib/auth-mode, ensuring consistency and preventing logic drift.import.meta.envpassing when calling the helper insettings.ts,posthog.tsx, andpreferences.tsx.src/defaults/settings.test.tsto verify the logic across different modes using mocked module behavior.Validation:
data_collectiondefaults tofalsewhenisOidcMode()is true.data_collectiondefaults totruefor consumer mode.bun test.Closes #701
Note
Low Risk
Low risk change that only flips the default for the
data_collectionsetting; primary impact is reduced/absent analytics unless a user explicitly opts in.Overview
Telemetry is now opt-in by default. The default
data_collectionsetting value is changed tofalse, and both PostHog initialization (getSettingsfallback) and the Preferences settings page (useSettingsdefaults) are updated to assume telemetry is disabled unless explicitly enabled.Reviewed by Cursor Bugbot for commit 71aca1d. Bugbot is set up for automated code reviews on this repo. Configure here.