Support for username property for ical#68
Open
mbartel wants to merge 1 commit into
Open
Conversation
kewisch
requested changes
Apr 19, 2026
Comment on lines
+72
to
+75
| if (username && username != calendar.getProperty("username")) { | ||
| matches = false; | ||
| } | ||
|
|
Member
There was a problem hiding this comment.
I think we should gate being able to query by username behind some sort of permission. Maybe accountsRead?
Member
There was a problem hiding this comment.
@jobisoft Thoughts on this? Am I being too cautious?
| "showReminders": { "type": "boolean" }, | ||
| "color": { "type": "string", "optional": true }, | ||
| "capabilities": { "$ref": "CalendarCapabilities", "optional": true } | ||
| "capabilities": { "$ref": "CalendarCapabilities", "optional": true }, |
Member
There was a problem hiding this comment.
Looking at the original patch for the username addition, it appears there is also a capability for usernames. Maybe we should add it to CalendarCapabilities and add a check in the provider code while we're at it?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implemented support for "username" property needed by CalDav for the username field in the UI