Skip to content

[codex] Clamp loaded item dimensions to limits#1000

Open
nexiumbiz-debug wants to merge 1 commit into
tiberiuzuld:masterfrom
nexiumbiz-debug:codex/clamp-loaded-item-size-284
Open

[codex] Clamp loaded item dimensions to limits#1000
nexiumbiz-debug wants to merge 1 commit into
tiberiuzuld:masterfrom
nexiumbiz-debug:codex/clamp-loaded-item-size-284

Conversation

@nexiumbiz-debug

Copy link
Copy Markdown
Contributor

Summary

  • clamp loaded gridster item cols/
    ows against item-level or grid-level min/max limits before collision handling
  • update the caller's item config when clamping changes dimensions
  • emit itemChange for loaded items whose dimensions are normalized

Fixes #284.

Validation

  • npm run test-lib -- --watch=false
  • npm run build-lib
  • npx eslint projects/angular-gridster2/src/lib/tests/gridster.spec.ts
  • npx eslint projects/angular-gridster2/src/lib/gridster.ts projects/angular-gridster2/src/lib/tests/gridster.spec.ts (blocked by pre-existing upstream gridster.ts lint errors: component selector, prefer-for-of, no-inferrable-types, unused eslint-disable)
  • git diff --check

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

bug max/min item cols/rows does not limit rows,cols if not resize

1 participant