[codex] Preserve scroll rows during drag#1003
Open
nexiumbiz-debug wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
scrollVerticalrow count from shrinking while an item is being dragged or resizedFixes #794.
Root cause
setGridDimensions()recalculates row count from the current item positions on every layout update. InscrollVertical, dragging an item upward can reduce the computed row count while the pointer is still inside the grid, which shrinks the grid underneath the drag and amplifies the movement.Validation
npx prettier --check projects/angular-gridster2/src/lib/gridster.ts projects/angular-gridster2/src/lib/tests/gridster.spec.tsnpx eslint projects/angular-gridster2/src/lib/tests/gridster.spec.ts(only the pre-existing Node module-type warning)npm run test-lib -- --watch=falsenpm run build-libgit diff --check(only the repo's LF/CRLF warning)