Skip to content

[codex] Reset drag position after cancelled stop#1008

Open
nexiumbiz-debug wants to merge 1 commit into
tiberiuzuld:masterfrom
nexiumbiz-debug:codex/reset-drag-position-on-cancel-694
Open

[codex] Reset drag position after cancelled stop#1008
nexiumbiz-debug wants to merge 1 commit into
tiberiuzuld:masterfrom
nexiumbiz-debug:codex/reset-drag-position-on-cancel-694

Conversation

@nexiumbiz-debug

Copy link
Copy Markdown
Contributor

Summary

  • reset draggable position bookkeeping when a rejected stop callback cancels a drag
  • keep restored $item coordinates and exposed drag.positionX/Y in sync
  • add regression coverage for cancelled drags

Fixes #694

Validation

  • npx prettier --check projects/angular-gridster2/src/lib/gridsterDraggable.ts projects/angular-gridster2/src/lib/tests/gridsterDraggable.spec.ts
  • npx eslint projects/angular-gridster2/src/lib/tests/gridsterDraggable.spec.ts
  • git diff --check
  • npm run test-lib -- --watch=false
  • npm run build-lib

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

draggable.stop callback rejection - still contains old drag position

1 participant