Skip to content

[codex] Guard drag stop after destroy#994

Open
nexiumbiz-debug wants to merge 1 commit into
tiberiuzuld:masterfrom
nexiumbiz-debug:codex/guard-destroyed-drag-stop-850
Open

[codex] Guard drag stop after destroy#994
nexiumbiz-debug wants to merge 1 commit into
tiberiuzuld:masterfrom
nexiumbiz-debug:codex/guard-destroyed-drag-stop-850

Conversation

@nexiumbiz-debug

Copy link
Copy Markdown
Contributor

Summary

  • remove active drag/resize event listeners during teardown before nulling interaction state
  • make late dragStop callbacks no-op after gridster/gridsterItem has been destroyed
  • add regression coverage for late draggable/resizable stop events after destroy

Fixes #850.
Fixes #864.
Fixes #849.

Validation

  • npm run test-lib -- --watch=false
  • npm run build-lib
  • npx eslint projects/angular-gridster2/src/lib/gridsterDraggable.ts projects/angular-gridster2/src/lib/gridsterResizable.ts projects/angular-gridster2/src/lib/tests/gridsterInteractionDestroy.spec.ts

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

1 participant