Skip to content

fix: classify code-review findings during verification - #65

Merged
timbrinded merged 3 commits into
masterfrom
fix/code-review-verified-categories
Oct 28, 2026
Merged

timbrinded merged 3 commits into
masterfrom
fix/code-review-verified-categories

Conversation

@timbrinded

@timbrinded timbrinded commented Oct 28, 2026 •

Copy link
Copy Markdown
Owner

Fixes #64.

Code-review verification now classifies findings as bug or cleanup from evidence, independently of the discovery lens. Cleanup-only reporting rules therefore apply to verified maintenance findings rather than suppressing behavioral defects discovered through simplification or conventions lenses.

  • Require classification in both individual and batch verifier schemas while preserving the existing contracts of other advisory workflows.
  • Preserve discovery lenses as engine-owned metadata, along with candidate IDs and evidence, through deduplication and synthesis.
  • Keep merged code-review findings classified as bugs when any selected evidence verifies a behavioral failure, preserving existing primary-source anchors, fallback recommendations, and sibling workflow behavior.

Validation: bun run typecheck and bun run test pass (679 tests). Deterministic regressions were demonstrated failing before their repairs for individual and batched verification, mixed-category synthesis, and primary-source preservation.

Correctness and thermonuclear maintainability reviews completed; their findings are addressed.

@timbrinded
timbrinded marked this pull request as ready for review October 28, 2026 12:18
Copilot AI balanced review requested due to automatic review settings October 28, 2026 12:18
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 28, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
🔒 Security Review ✅ Completed 2026-10-28T12:22:34.173598Z d457ffd Draft marked ready
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approval recommended

No active review issues remain for the verification-time classification and provenance changes.

No open issues 🎉

What changed in this PR

Addresses #64 by classifying code-review findings during verification rather than fixing their category to the discovery lens. This keeps behavioral bugs eligible for reporting when cleanup-only filters apply.

Changes:

  • Require evidence-based bug or cleanup classification in individual and batch code-review verification.
  • Preserve discovery lenses, candidate identities, and evidence through merging and synthesis.
  • Add deterministic regressions for cleanup filtering, mixed-category merging, and primary-source preservation.
File Description
tests/​advisory-utils.test.ts Tests primary-source preservation for other advisory categories.
tests/​advisory-scheduling.test.ts Checks that verifiers cannot overwrite discovery lenses.
tests/​advisory-provenance.test.ts Tests verified-category filtering, merged bugs, and provenance.
tests/​advisory-merge.test.ts Adds discovery lenses to merge fixtures.
.pi/​extensions/​pi-workflow-engine/​workflows/​code-review.ts Enables verification classification and preserves bug status in merged findings.
.pi/​extensions/​pi-workflow-engine/​src/​workflow-advisory-utils.ts Applies verifier categories and carries lenses into final findings.
.pi/​extensions/​pi-workflow-engine/​src/​advisory-schema.ts Adds configurable classification schemas and lens metadata.
.pi/​extensions/​pi-workflow-engine/​src/​advisory-evidence.ts Assigns and merges engine-owned discovery lenses.

Review effort: Balanced

@timbrinded
timbrinded merged commit d43739f into master Oct 28, 2026
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Code-review lens category can suppress verified behavioral bugs

2 participants