Repository navigation
fix: classify code-review findings during verification - #65
Merged
Merged
Conversation
timbrinded
marked this pull request as ready for review
October 28, 2026 12:18
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
There was a problem hiding this comment.
🟢 Approval recommended
No active review issues remain for the verification-time classification and provenance changes.
No open issues 🎉
What changed in this PR
Addresses #64 by classifying code-review findings during verification rather than fixing their category to the discovery lens. This keeps behavioral bugs eligible for reporting when cleanup-only filters apply.
Changes:
- Require evidence-based
bugorcleanupclassification in individual and batch code-review verification. - Preserve discovery lenses, candidate identities, and evidence through merging and synthesis.
- Add deterministic regressions for cleanup filtering, mixed-category merging, and primary-source preservation.
| File | Description |
|---|---|
tests/advisory-utils.test.ts |
Tests primary-source preservation for other advisory categories. |
tests/advisory-scheduling.test.ts |
Checks that verifiers cannot overwrite discovery lenses. |
tests/advisory-provenance.test.ts |
Tests verified-category filtering, merged bugs, and provenance. |
tests/advisory-merge.test.ts |
Adds discovery lenses to merge fixtures. |
.pi/extensions/pi-workflow-engine/workflows/code-review.ts |
Enables verification classification and preserves bug status in merged findings. |
.pi/extensions/pi-workflow-engine/src/workflow-advisory-utils.ts |
Applies verifier categories and carries lenses into final findings. |
.pi/extensions/pi-workflow-engine/src/advisory-schema.ts |
Adds configurable classification schemas and lens metadata. |
.pi/extensions/pi-workflow-engine/src/advisory-evidence.ts |
Assigns and merges engine-owned discovery lenses. |
Review effort: Balanced
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #64.
Code-review verification now classifies findings as
bugorcleanupfrom evidence, independently of the discovery lens. Cleanup-only reporting rules therefore apply to verified maintenance findings rather than suppressing behavioral defects discovered through simplification or conventions lenses.Validation:
bun run typecheckandbun run testpass (679 tests). Deterministic regressions were demonstrated failing before their repairs for individual and batched verification, mixed-category synthesis, and primary-source preservation.Correctness and thermonuclear maintainability reviews completed; their findings are addressed.