Skip to content

Buildingpit3d bugfix #117

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mbakker7 merged 4 commits into from
May 21, 2026
Merged

Buildingpit3d bugfix #117

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
4e3be44
Update besselnumba.py
mbakker7 May 20, 2026
ee64d67
fix param_3d return values
mbakker7 May 20, 2026
16747f1
long line to print to readable string
mbakker7 May 20, 2026
84fd0a2
How dumb is that? You must supply a strict=False part.
mbakker7 May 20, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions timflow/bessel/besselnumba.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,7 @@

fac = 1.0

# max number of terms fixed to 20
nrange = np.arange(21, dtype=np.float64)

a = np.zeros(21, dtype=np.float64)
Expand Down
14 changes: 10 additions & 4 deletions timflow/steady/inhomogeneity.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -424,7 +424,7 @@ def __repr__(self):
"BuildingPit: layers "
+ str(list(self.layers))
+ ", "
+ str(list(self.x, self.y))
+ str(list(zip(self.x.tolist(), self.y.tolist(), strict=False)))
)

def isinside(self, x, y):
Expand Down Expand Up @@ -687,7 +687,9 @@ def __init__(
layers = [0]
if z is None:
z = [1, 0]
(kaq, c, npor, ltype) = param_3d(kaq, z, kzoverkh, npor, topboundary, topres)
kaq, kzoverkh, c, npor, ltype = param_3d(
kaq, z, kzoverkh, npor, topboundary, topres
)
if topboundary == "semi":
z = np.hstack((z[0] + topthick, z))
super().__init__(
Expand All @@ -703,6 +705,7 @@ def __init__(
ndeg=ndeg,
layers=layers,
)
self.kzoverkh = kzoverkh # add kzoverkh to inhomogeneity object


class LeakyBuildingPit(BuildingPit):
Expand Down Expand Up @@ -812,7 +815,7 @@ def __repr__(self):
"LeakyBuildingPit: layers "
+ str(list(self.layers))
+ ", "
+ str(list(self.x, self.y))
+ str(list(zip(self.x.tolist(), self.y.tolist(), strict=False)))
)

def create_elements(self):
Expand Down Expand Up @@ -1060,7 +1063,9 @@ def __init__(
layers = [0]
if z is None:
z = [1, 0]
(kaq, c, npor, ltype) = param_3d(kaq, z, kzoverkh, npor, topboundary, topres)
kaq, kzoverkh, c, npor, ltype = param_3d(
kaq, z, kzoverkh, npor, topboundary, topres
)
if topboundary == "semi":
z = np.hstack((z[0] + topthick, z))
super().__init__(
Expand All @@ -1077,6 +1082,7 @@ def __init__(
layers=layers,
res=res,
)
self.kzoverkh = kzoverkh # add kzoverkh to inhomogeneity object


class AreaSinkInhom(Element):
Expand Down