Skip to content

Add regression coverage for run_vulkan launcher path selection#46

Draft
cursor[bot] wants to merge 1 commit intonext-gen-5from
cursor/regression-test-coverage-f855
Draft

Add regression coverage for run_vulkan launcher path selection#46
cursor[bot] wants to merge 1 commit intonext-gen-5from
cursor/regression-test-coverage-f855

Conversation

@cursor
Copy link
Copy Markdown

@cursor cursor bot commented Apr 5, 2026

Summary

  • Add a deterministic script-level regression test for scripts/run_vulkan.sh.
  • Register the new test in CTest as regression_run_vulkan_launcher.

Risky behavior now covered

  • Launcher path resolution when invoked from scripts/ now correctly prefers sibling ../release binaries.
  • Architecture-specific binary selection (idtech3.aarch64 on aarch64) and fallback to idtech3 when arch-specific binary is missing.
  • Argument forwarding to the selected engine executable remains intact.

Test files added/updated

  • Added: tests/scripts/test_run_vulkan.sh
  • Updated: CMakeLists.txt (adds CTest registration)

Why this materially reduces regression risk

  • run_vulkan.sh recently changed engine discovery behavior; regressions here can silently launch the wrong binary or fail on ARM systems.
  • The new tests exercise real execution paths with isolated stubs and controlled uname -m responses, avoiding GPU/game-data dependencies while validating high-impact launcher behavior.
  • Coverage targets a shared launcher used in core start-up workflows, giving high signal for low maintenance cost.

Validation

  • bash tests/scripts/test_run_vulkan.sh /workspace/scripts/run_vulkan.sh
  • ctest --test-dir /workspace/build-vk-Release -R regression_run_vulkan_launcher --output-on-failure
Open in Web View Automation 

Co-authored-by: Tim Fox <timfox@outlook.com>
@cursor cursor bot deleted the branch next-gen-5 April 6, 2026 15:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant