Add regression coverage for run_vulkan launcher path selection#46
Draft
cursor[bot] wants to merge 1 commit intonext-gen-5from
Draft
Add regression coverage for run_vulkan launcher path selection#46cursor[bot] wants to merge 1 commit intonext-gen-5from
cursor[bot] wants to merge 1 commit intonext-gen-5from
Conversation
Co-authored-by: Tim Fox <timfox@outlook.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
scripts/run_vulkan.sh.regression_run_vulkan_launcher.Risky behavior now covered
scripts/now correctly prefers sibling../releasebinaries.idtech3.aarch64onaarch64) and fallback toidtech3when arch-specific binary is missing.Test files added/updated
tests/scripts/test_run_vulkan.shCMakeLists.txt(adds CTest registration)Why this materially reduces regression risk
run_vulkan.shrecently changed engine discovery behavior; regressions here can silently launch the wrong binary or fail on ARM systems.uname -mresponses, avoiding GPU/game-data dependencies while validating high-impact launcher behavior.Validation
bash tests/scripts/test_run_vulkan.sh /workspace/scripts/run_vulkan.shctest --test-dir /workspace/build-vk-Release -R regression_run_vulkan_launcher --output-on-failure