Vulkan: remove dead USE_UPLOAD_QUEUE compile-time branches#52
Draft
cursor[bot] wants to merge 1 commit intomainfrom
Draft
Vulkan: remove dead USE_UPLOAD_QUEUE compile-time branches#52cursor[bot] wants to merge 1 commit intomainfrom
cursor[bot] wants to merge 1 commit intomainfrom
Conversation
The macro was never defined in-tree, so only the #else paths ran. Drop the unused staging-queue helpers and simplify upload/submit code to match the active synchronous staging path. Co-authored-by: Tim Fox <timfox@outlook.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Removes the unused
USE_UPLOAD_QUEUEcompile-time feature gate. The macro was never defined anywhere in the build, so only the#else(synchronous staging + per-upload command buffer) path ever ran.Flags removed
USE_UPLOAD_QUEUE(compile-time only; not a cvar)Why it is safe to delete
USE_UPLOAD_QUEUEis not defined in CMake, headers, or compile definitions, so the “upload queue” path was unreachable dead code.vk_begin_command_buffer/vk_end_command_buffer, single-semaphore frame submit.Behavioral parity checks
./scripts/compile_engine.sh vulkan(Release) — successctestinbuild-vk-Release— all 17 tests passed (smoke, renderer regression, unit tests)