Skip to content

Drop setAllowUniversalAccessFromFileURLs in ControlPanelFragment #10

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
jim-daf wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Drop setAllowUniversalAccessFromFileURLs in ControlPanelFragment #10

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion ...emoteControl/src/main/java/com/github/timnew/smartremotecontrol/ControlPanelFragment.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,8 +43,12 @@ protected void afterView() {
WebSettings settings = panel.getSettings();
settings.setJavaScriptEnabled(true);
settings.setAllowContentAccess(true);
// Panel JS calls $.getJSON on a sibling file:// JSON file under
// file:///android_asset/panels/<name>/, which needs file-from-file
// XHR. allowUniversalAccessFromFileURLs is not needed because the
// panel never XHRs an http or https origin, and on minSdk it
// would let any panel exfiltrate to any host.
settings.setAllowFileAccessFromFileURLs(true);
settings.setAllowUniversalAccessFromFileURLs(true);

panel.addJavascriptInterface(emitter, "ir");
panel.setWebViewClient(new WebViewClient() {
Expand Down