Support Kafka IAM auth fields#160
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
defineKafkaConnection..connectiondirectives:KAFKA_SASL_OAUTHBEARER_METHODKAFKA_SASL_OAUTHBEARER_AWS_REGIONKAFKA_SASL_OAUTHBEARER_AWS_ROLE_ARNKAFKA_SASL_OAUTHBEARER_AWS_EXTERNAL_ID.connectionfiles round-trip into SDK definitions.@tinybirdco/sdkto0.0.74.Why
../analyticssupports Kafka IAM authentication through those OAUTHBEARER AWS fields in connection datafiles. The SDK can now author and migrate those definitions.Example
Authoring the connection in TypeScript:
Generated
.connectiondatafile, which is also what migration parsing reads later:When migrating that datafile back to TypeScript, the parser emits the same SDK options:
Validation
pnpm vitest run src/schema/connection.test.ts src/generator/connection.test.ts src/migrate/parse-connection.test.ts src/cli/commands/migrate.test.tspnpm typecheckpnpm test:runpnpm build