Skip to content

[codex] Delete previous deployment after promotion#166

Merged
rmorehig merged 3 commits into
mainfrom
codex/delete-previous-deployment-after-set-live
Jun 9, 2026
Merged

[codex] Delete previous deployment after promotion#166
rmorehig merged 3 commits into
mainfrom
codex/delete-previous-deployment-after-set-live

Conversation

@rmorehig

@rmorehig rmorehig commented Jun 9, 2026

Copy link
Copy Markdown
Collaborator

Summary

  • Track the previously live deployment before starting a normal TS SDK deploy.
  • After the new deployment is successfully set live, delete the previous live deployment so it does not remain in staging.
  • Add unit coverage for the manual promote/delete flow and live e2e coverage that polls the deployments API for the previous deployment to become deleted.

Why

The TS SDK deploy flow was doing the manual set-live step but was missing the old deployment cleanup that the Python CLI performs in its manual promotion path. That could leave the previous deployment visible as staging after a successful deploy.

Validation

  • pnpm vitest run src/api/deploy.test.ts
  • pnpm typecheck
  • pnpm test:e2e:live -- e2e-live/deploy.test.ts (skipped locally because live Tinybird e2e credentials are not configured)
  • pnpm build

@rmorehig rmorehig marked this pull request as ready for review June 9, 2026 11:12
@rmorehig

rmorehig commented Jun 9, 2026

Copy link
Copy Markdown
Collaborator Author

@cursor review

@cursor

cursor Bot commented Jun 9, 2026

Copy link
Copy Markdown

Skipping Bugbot: Bugbot is disabled for this repository. Visit the Bugbot dashboard to update your settings.

@rmorehig rmorehig merged commit 3f1a5cb into main Jun 9, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant