Repository navigation
fix(approval): preserve abandoned execution outcomes #43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
senamakel
wants to merge
18
commits into
main
Choose a base branch
from
fix/abandoned-approval-outcome
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
18 commits
Select commit
Hold shift + click to select a range
98d3786
test(tinysecurity-bus): cover abandoned execution outcome wire round-…
senamakel 6d5113f
feat(bus): add abandoned execution outcome
senamakel e7c851b
test(approval): cover abandoned execution as immutable unknown effect
senamakel b05b8da
test(bus): bump expected contract version to 1.28
senamakel bf8752d
test(bus): cover contract major bump compatibility
senamakel 9a3a2e8
feat(bus): add abandoned execution outcome and bump contract to 2.0
senamakel 52bb2f4
test(tinysecurity-bus): drop incorrect compatibility assertion
senamakel e47934a
Merge remote-tracking branch 'origin/main' into fix/abandoned-approva…
senamakel 4f6c5db
test(module): bump contract version in reinit test
senamakel 9453476
test: cover mode 14 and contract version 1.28 in fixtures
senamakel 611590f
refactor(tinysecurity-module): use range pattern for mode check
senamakel 7592cb4
Merge upstream main into abandoned approval outcome
senamakel 35c5395
docs: move approval execution outcomes to a spec
senamakel 9e379a7
docs: fix approval contract link
senamakel 4c99780
test(secret-cipher): raise fixture timeout above audit budget
senamakel 7a141aa
refactor(examples): reuse timed proxy in secret cipher fixture
senamakel 4fe3eee
fix(tinysecurity-module): raise native contract fixture bus timeout
senamakel c49f856
Merge remote-tracking branch 'origin/main' into fix/abandoned-approva…
senamakel File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,12 @@ | ||
| # Approval execution outcomes | ||
|
|
||
| Contract 2.0 adds `ExecutionOutcome::Abandoned` for an in-flight execution that | ||
| was abandoned before the host could determine its effects. It is persisted as | ||
| an immutable terminal outcome and does not claim that the tool had no effects. | ||
| Use `Cancelled` only when the host has a definite cancelled result. A host that | ||
| sees the legacy `aborted` value maps it to `Abandoned` because aborting a wait or | ||
| task does not prove that execution had no effects. | ||
|
|
||
| This closed enum change is a contract-major bump: a 1.x host cannot safely | ||
| decode an `abandoned` result, so 1.x hosts reject a 2.x module during version | ||
| compatibility checks. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.